Add show back cover #1030
Open
Add show back cover #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 10, 2020 14:54
Opens a popup during click on tiny cover within library. The popup shows the back cover and can be dismissed by a click on itself or the background.
…o AddShowBackCover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to show the back cover of an album. I added this feature to be able to read the descriptions of audio books and audio dramas. It helps me to distinguish single episodes.
Thats how it looks:
I added a onClick Handler for each entry of mediatype 'Album'. The click event is filtered within the LibraryPagerAdapter and requests the backcover from the CoverCache. The cover will be displayed within a popup. This can be dismissed with a click on itself or a click on the background.
Feel free to suggest some changes!
Note: I did not merge the master branch of vanilla-music/vanilla repo into the PR branch yet, since there are currently no conflicts.