Show cover art of songs not in albums #1122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locations and files of songs would be checked every time for album art. This commit puts songs with no album art in the cover cache with null size and blob. Getting these songs from cache returns the fallback cover.
|
Would be interested in this as well. Any update? Any way to help out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a song is not in an album, the app will not show cover art that's embedded in the file.
This PR adds a new flag to
Songto determine if it is in an album. If it is, the app in other places will use the cover from the album it is in, thus caching and loading it only once. If it's not, it will use the Song's ID to cache the album art.I spent a few hours on this before realizing that the
unique-coverbranch has existed since 2016, however it has not had any activity ever since. This PR also differs from that branch because that branch just made it so every song's art is cached.