Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutiple selection in playback queue #961

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Mutiple selection in playback queue #961

wants to merge 5 commits into from

Conversation

wchen342
Copy link
Contributor

@wchen342 wchen342 commented Jun 7, 2019

I have implemented a basic multiple selection. Currently it only works in the playback queue as a demonstration of what the implementation will be like. Please provide some feedbacks so I can further improve the implementation. If this implementation looks ok then I can do it for playlist and file viewer too.

query.data = id;
} else if (type == MediaUtils.TYPE_FILE) {
query = MediaUtils.buildFileQuery(intent.getStringExtra(LibraryAdapter.DATA_FILE), projection, true /* recursive */);
Object id = intent.getExtras().get("id");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either:

  • make 'id' to always be an array
  • ...or use a new key for cases where we pass in an array (get("id_list") ? )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I went with the second approach since there are too many places using "id". See the update.

@adrian-bl
Copy link
Member

Thanks a lot for looking into this: i like the prototype so far.

I'd suggest to keep the focus on the queue for now: Once we get this into a working state, we can merge it and then later start working on the library view code.

@wchen342
Copy link
Contributor Author

I had a problem when I tried to use WHERE...IN with VIEW_SONGS_ALBUMS_ARTISTS then I got a so such column error caused by _genre_id, so the column is currently not there? Then how the original enqueue from genre worked?

@adrian-bl
Copy link
Member

The database code has a special view for genre queries (as these are much more expensive) and attempts to auto-select the correct view, looks like this fails in this case.

Don't worry about that: throwing the exception is fine for now: i can have a look at this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants