Fix #34: don't JSON.parse delete events' IDs #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #34, we shouldn't
JSON.parse
delete
events' payload because it's a stringy ID and needs to remain a string to avoid exceeding float precision issues.This appears to be the only event for which this is the case, per Mastodon docs (no other events mention
string ID
). Therefore, this PR proposes a simple solution: skipJSON.parse
ing the event payload if it's a delete.With this in place, the following streaming data chunk:
is parsed into
{ event: 'delete', data: '110988741790818968' }
as expected (and notparseInt('110988741790818968')
which is 110988741790818980…). All other events are processed as before.