Remove rank and let dot do the ranking. (#42)

vanniktech · Apr 19, 2018 · 87523ad · 87523ad
1 parent 1c1d21d
commit 87523ad
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 8 deletions.
diff --git a/src/main/kotlin/com/vanniktech/dependency/graph/generator/DotGenerator.kt b/src/main/kotlin/com/vanniktech/dependency/graph/generator/DotGenerator.kt
@@ -36,12 +36,6 @@ internal class DotGenerator(
       addedDependencies.add(projectId)
     }
 
-    if (projects.size > 1) {
-      // All projects should be displayed on the same level.
-      val ranking = projects.joinToString(separator = "; ") { "\"${it.dotIdentifier}\"" }
-      content.append("  { rank = same; $ranking };\n")
-    }
-
     // Let's gather everything and put it in the file.
     projects
         .flatMap { project ->

diff --git a/...test/java/com/vanniktech/dependency/graph/generator/DependencyGraphGeneratorPluginTest.kt b/...test/java/com/vanniktech/dependency/graph/generator/DependencyGraphGeneratorPluginTest.kt
@@ -188,7 +188,6 @@ class DependencyGraphGeneratorPluginTest {
         |  $lib [label="lib", shape="box"];
         |  $lib1 [label="lib1", shape="box"];
         |  $lib2 [label="lib2", shape="box"];
-        |  { rank = same; "$app"; "$lib"; "$lib1"; "$lib2" };
         |  $app -> $lib1;
         |  $lib1 -> $lib;
         |  ioreactivexrxjava2rxjava [label="rxjava", shape="box"];

diff --git a/src/test/java/com/vanniktech/dependency/graph/generator/DotGeneratorTest.kt b/src/test/java/com/vanniktech/dependency/graph/generator/DotGeneratorTest.kt
@@ -203,7 +203,6 @@ class DotGeneratorTest {
         |digraph G {
         |  multimulti1 [label="multi1", shape="box"];
         |  multimulti2 [label="multi2", shape="box"];
-        |  { rank = same; "multimulti1"; "multimulti2" };
         |  orgjetbrainskotlinkotlinstdlib [label="kotlin-stdlib", shape="box"];
         |  multimulti1 -> orgjetbrainskotlinkotlinstdlib;
         |  orgjetbrainsannotations [label="jetbrains-annotations", shape="box"];