Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expand to product endpoints #260

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

cball
Copy link
Contributor

@cball cball commented Jun 14, 2024

This adds expand to products in the same way its being used throughout the rest of the library.

While it would be nice to be able to do this without a breaking change, I think it's more important to keep things consistent in the approach. This means that anyone using these product endpoints will have to update their code to pass nil for expand.

Let me know if anything additional is needed here.

@cball cball requested a review from Andrewangeta as a code owner June 14, 2024 12:34
@cball cball force-pushed the cball-add-expand branch from a6c86b5 to 2a07ad2 Compare June 14, 2024 12:36
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@3c2d6ea). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #260   +/-   ##
======================================
  Coverage        ?   2.15%           
======================================
  Files           ?     194           
  Lines           ?    8864           
  Branches        ?       0           
======================================
  Hits            ?     191           
  Misses          ?    8673           
  Partials        ?       0           
Files Coverage Δ
...es/StripeKit/Products/Products/ProductRoutes.swift 0.00% <0.00%> (ø)

@Andrewangeta Andrewangeta merged commit 1d9fbc3 into vapor-community:main Jul 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants