Main site components #104
Main site components #104
Conversation
… out into own page
gwynne
force-pushed
the
main-site-components
branch
3 times, most recently
from
311cd8e to
1d1909f
Compare
gwynne
force-pushed
the
main-site-components
branch
from
1d1909f to
9a1ac69
Compare
There was a problem hiding this comment.
Ok this is really awesome! I have a few requests, mainly around the use of rgba() with hardcoded rgb values instead of SASS variables.
Finally, there are a couple of things we need to fix.
- As the nabber for the homepage will be fixed (and likely on other pages) we should add a new CSS class for
fixed-navbarthat sets the Z value so it sits on top of everything and set the background correctly (see below)
- Second, the hero image on the blog page has changed. It should be different on the main page and the same on all the other pages IIRC. See below
Finally, we have a few fixes for mobile to do.
- Sponsors section needs mobile design added
- Spacing throughout can be tightened up, e.g.
Finally, these should be centered:
Awesome work though!
src/scss/vapor/main-site.scss
Outdated
| } | ||
|
|
||
| .blurry-background { | ||
| background: linear-gradient(230.51deg, rgba(35, 172, 240, 0.25) 27.41%, rgba(223, 62, 251, 0.25) 67%, rgba(112, 25, 128, 0.25) 80.12%); |
There was a problem hiding this comment.
I have been extracting out these rgba values into our colours so they look something like rgba($grey-100, 0.25), would be great if you could do that here where you're using RGBA unless they don't line up with any hex values we have
There was a problem hiding this comment.
IMO this specific one is fine as it is because it's a gradient, the colours inside are specific to create this gradient and unlikely to be reused
No description provided.