Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise some main site styles #190

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Finalise some main site styles #190

merged 3 commits into from
Jun 17, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Jun 15, 2024

No description provided.

@ptoffy ptoffy requested a review from 0xTim as a code owner June 15, 2024 15:22
@ptoffy ptoffy marked this pull request as draft June 15, 2024 15:24
@ptoffy ptoffy marked this pull request as ready for review June 15, 2024 16:22
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the new line bracket formatting

func makeIndexHTML(for index: Index,
context: PublishingContext<Site>) throws -> HTML {
context: PublishingContext<Site>) throws -> HTML
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What formatting option is this? Because it should be burned 😆

Sources/DesignSite/DesignTheme.swift Show resolved Hide resolved
Sources/DesignSite/DesignTheme.swift Show resolved Hide resolved
src/scss/vapor/main-site.scss Show resolved Hide resolved
@ptoffy ptoffy requested a review from 0xTim June 17, 2024 05:29
@ptoffy ptoffy merged commit b754c36 into main Jun 17, 2024
1 check passed
@ptoffy ptoffy deleted the updates branch June 17, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants