Make scrolling more generic #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
requested changes
Jul 15, 2024
|
@0xTim I added sponsors to be able to see how scrolling works when there are more |
|
Ok we can test the hiding on the main page then. Other option is move the sponsors card to the design page that contains all the elements |
0xTim
approved these changes
Jul 15, 2024
0xTim
requested changes
Jul 17, 2024
| background: $grey-300; | ||
| } | ||
|
|
||
| &.disabled { |
There was a problem hiding this comment.
We need dark mode versions of the disabled state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use the scrolling buttons all over the page rather than just in the showcase