Handle aggregate types a very tiny bit better #569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds explicit forwarding of the generic
Result
parameter of the twoQueryBuilder.aggregate()
variants which weren't doing so already. It was already being implicitly forwarded due to type inference, but better to do so explicitly.Also adds notes to the
sum()
andaverage()
sets of methods warning that theField.Value
return types are not always correct (usually only causes problems with Postgres) and giving the workaround. This is related to #379 and vapor/fluent-postgres-driver#166 but does NOT fix those issues; it only clarifies one of the ways to get around the problem.