Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async APIs for shutting down the databases #614

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Jul 31, 2024

These changes are now available in 1.49.0

To enable removing calls to .wait() in the connection pools when in an async context

@0xTim 0xTim added the semver-minor Contains new APIs label Jul 31, 2024
@0xTim 0xTim requested a review from gwynne as a code owner July 31, 2024 16:10
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 24.78%. Comparing base (cff1c3e) to head (22074e2).

Files Patch % Lines
Sources/FluentKit/Database/Databases.swift 0.00% 8 Missing ⚠️
Sources/FluentKit/Database/Database.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   24.80%   24.78%   -0.03%     
==========================================
  Files         149      149              
  Lines        8650     8660      +10     
==========================================
  Hits         2146     2146              
- Misses       6504     6514      +10     
Files Coverage Δ
Sources/FluentKit/Database/Database.swift 73.68% <0.00%> (-8.67%) ⬇️
Sources/FluentKit/Database/Databases.swift 0.00% <0.00%> (ø)

@gwynne gwynne merged commit 614d3ec into main Aug 11, 2024
12 checks passed
@gwynne gwynne deleted the async-shutdown branch August 11, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants