Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sorting joined tables #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kstefanou52
Copy link

Issue

Mongo driver didn't support to query results with sorting option for joined tables as describing here.

Enable sorting for joined tables

@0xTim 0xTim requested a review from Joannis December 23, 2022 22:45
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could've sworn I left a review already, but it seems I posted my feedback on Discord. Thanks for the ping @0xTim .

The main thing preventing approval is the missing some tests

@Joannis
Copy link
Member

Joannis commented Dec 24, 2022

@gwynne is it doable to add these type of tests to FluentKit?

@kstefanou52 kstefanou52 force-pushed the enable_sorting_joined_tables branch from ec79b7e to 000a562 Compare October 5, 2023 08:15
@kstefanou52 kstefanou52 requested a review from gwynne as a code owner October 5, 2023 08:15
@codecov-commenter
Copy link

Codecov Report

Merging #53 (ec79b7e) into main (a4237b9) will increase coverage by 2.34%.
Report is 1 commits behind head on main.
The diff coverage is 95.65%.

❗ Current head ec79b7e differs from pull request most recent head 000a562. Consider uploading reports for the commit 000a562 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   72.59%   74.93%   +2.34%     
==========================================
  Files          20       20              
  Lines         686      826     +140     
==========================================
+ Hits          498      619     +121     
- Misses        188      207      +19     
Files Coverage Δ
...ources/FluentMongoDriver/DatabaseQuery+Mongo.swift 100.00% <100.00%> (+3.22%) ⬆️
Sources/FluentMongoDriver/MongoDB+Join.swift 69.60% <100.00%> (+14.13%) ⬆️
Sources/FluentMongoDriver/MongoDB+Read.swift 93.18% <100.00%> (+1.07%) ⬆️
Sources/FluentMongoDriver/Sort.swift 89.28% <93.75%> (+9.28%) ⬆️

... and 16 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants