Use the specified the index name above the default name #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
requested changes
Jun 11, 2023
| func prepare(on database: Database) -> EventLoopFuture<Void> { | ||
| database | ||
| .schema("index-tests") | ||
| .field("name", .string, .required) |
There was a problem hiding this comment.
Suggested change
| .field("name", .string, .required) | |
| .compositeIdentifier(over: "name", "email") | |
| .field("name", .string, .required) |
In light of my remarks above (and since it'll just translate to an additional unique index for Mongo)
| @@ -146,6 +146,10 @@ final class FluentMongoDriverTests: XCTestCase { | |||
| XCTFail("\(error)") | |||
| } | |||
| } | |||
|
|
|||
| func testDuplicateIndexNames() throws { | |||
| XCTAssertNoThrow(try DuplicateIndexMigration().prepare(on: self.db).wait()) | |||
There was a problem hiding this comment.
IIUC this won't actually test anything; the original reporter said in Discord that only one index gets created, not that an error is thrown. Is there a way to verify the indexes were actually added? Or alternatively, can we either 1) check for duplicates and throw an error in the schema logic, or 2) ask MongoDB to reject duplicates somehow?
gwynne
reviewed
Jun 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 72.59% 73.05% +0.46%
==========================================
Files 20 20
Lines 686 694 +8
==========================================
+ Hits 498 507 +9
+ Misses 188 187 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.