Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipartKit V5 #100

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

MultipartKit V5 #100

wants to merge 12 commits into from

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Oct 7, 2024

No description provided.

@ptoffy ptoffy added the semver-major Breaking changes label Oct 7, 2024
@ptoffy ptoffy self-assigned this Oct 7, 2024
Copy link
Contributor

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

Sources/MultipartKit/MultipartParser+AsyncStream.swift Outdated Show resolved Hide resolved
Sources/MultipartKit/MultipartParser.swift Outdated Show resolved Hide resolved
Sources/MultipartKit/MultipartParser+AsyncStream.swift Outdated Show resolved Hide resolved
Sources/MultipartKit/MultipartParser.swift Show resolved Hide resolved
@ptoffy
Copy link
Member Author

ptoffy commented Oct 30, 2024

@adam-fowler Do you want to take a look at this again and see if stuff makes more sense now? I added in some binary data (which even contains hex-CRLF 😄) to the tests so it should be able to parse anything now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants