better logging in SO-checker

vapor · Oct 13, 2023 · 02d51ec · 02d51ec
1 parent eb4e6d2
commit 02d51ec
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/Sources/Penny/Services/StackoverflowService /DefaultSOService.swift b/Sources/Penny/Services/StackoverflowService /DefaultSOService.swift
@@ -1,9 +1,11 @@
 import AsyncHTTPClient
 import NIOCore
+import Logging
 import Foundation
 
 struct DefaultSOService: SOService {
     let httpClient: HTTPClient
+    let logger = Logger(label: "DefaultSOService")
     let decoder = JSONDecoder()
 
     func listQuestions(after: Date) async throws -> [SOQuestions.Item] {
@@ -22,6 +24,18 @@ struct DefaultSOService: SOService {
         let request = HTTPClientRequest(url: url)
         let response = try await httpClient.execute(request, deadline: .now() + .seconds(15))
         let buffer = try await response.body.collect(upTo: 1 << 25) /// 32 MB
+
+        guard 200..<300 ~= response.status.code else {
+            let collected = try? await response.body.collect(upTo: 1 << 16)
+            let body = collected.map { String(buffer: $0) } ?? "nil"
+            logger.error("SO-service failed", metadata: [
+                "status": "\(response.status)",
+                "headers": "\(response.headers)",
+                "body": "\(body)",
+            ])
+            throw ServiceError.badStatus(response.status)
+        }
+
         let questions = try decoder.decode(
             SOQuestions.self,
             from: buffer