Prefix Markdown Docs Based On Visible Text #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
reviewed
Aug 29, 2023
| @@ -71,6 +80,21 @@ extension String { | |||
| return lines.joined(separator: "\n") | |||
| } | |||
|
|
|||
| /// Doesn't count markdown attributes towards the limit. | |||
| @_disfavoredOverload | |||
There was a problem hiding this comment.
Why is this attribute needed? (Disfavored overloads are notoriously finicky at best.)
There was a problem hiding this comment.
The function names are the same.
Unless you can suggest a good function name for the functions that return both the remaining and the result, then we'll need to roll with this.
There was a problem hiding this comment.
I've basically duplicated the unicodesPrefix() function, one just returns the result, the other returns the remaining too.
gwynne
reviewed
Aug 29, 2023
| @@ -6,12 +6,17 @@ extension String { | |||
| ) ?? self | |||
| } | |||
|
|
|||
| public func unicodesPrefix(_ maxUnicodeScalars: Int) -> String { | |||
| @_disfavoredOverload | |||
gwynne
reviewed
Aug 29, 2023
gwynne
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Penny should prefix the text content of the markdown documents and not touch the markdown attributes of the document.
For example now, prefixing
```
Hello, how are you?
```
Would result in
```
Hello, how are ...
```
Instead of the previous
```
Hello, how are you?
Which used to remove the ``` markdown attributes.
Resolves a task of #100.