Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore reporting "Do Not Merge" PRs in Discord #293

Merged
merged 9 commits into from
Jan 21, 2025
Merged

Conversation

MahdiBM
Copy link
Collaborator

@MahdiBM MahdiBM commented Jan 20, 2025

So one can create a PR without spamming the Discord channel

@MahdiBM MahdiBM requested review from 0xTim and gwynne as code owners January 20, 2025 18:54
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me - I also think we should ignore drafts until they're ready for review and try and enforce this as best we can

Comment on lines +8 to +13
static let trustedGitHubUserIds: Set<Int64> = [
69_189_821, // Paul
9_938_337, // Tim
1_130_717, // Gwynne
54_685_446, // Mahdi
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this being hardcoded but I have no better suggestion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

author association stuff should usually kick in anyway ... this is just a fallback mechanism mostly.

@MahdiBM MahdiBM merged commit 1c38d5a into main Jan 21, 2025
12 checks passed
@MahdiBM MahdiBM deleted the mmbm-ignore-dnm branch January 21, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants