-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore reporting "Do Not Merge" PRs in Discord #293
Conversation
This reverts commit 0ac8d89.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine by me - I also think we should ignore drafts until they're ready for review and try and enforce this as best we can
static let trustedGitHubUserIds: Set<Int64> = [ | ||
69_189_821, // Paul | ||
9_938_337, // Tim | ||
1_130_717, // Gwynne | ||
54_685_446, // Mahdi | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this being hardcoded but I have no better suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
author association stuff should usually kick in anyway ... this is just a fallback mechanism mostly.
So one can create a PR without spamming the Discord channel