refactor: use static ChannelOptions instead of raw definitions #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
approved these changes
Mar 18, 2025
|
@gwynne any idea about CI failures? |
|
Yeah the tests use an old BoringSSL thing that no longer compiles - we need to fix it but latest macOS also broke some of the URL parsing. This is addressed in #155 I think, we need to check that in |
|
@Austinpayne can you bump the version of NIO that includes these changes in the manifest? I had a build failure when running locally because of outdated dependencies, then we can release (I'll bypass CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor to make better use of the Swift types exposed to set channel options.