Variety can't find metadata files because they get mislabled on downloaded #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause, metadata will have '.partial' in it's name; and variety won't be able to find it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed Variety would name image metadata files with the image's partial filename causing Variety to fail to find them later. So I thought the best solution is to rename the image to it's proper one before writing a metadata. I also had some code accommodating for this bug by checking if a 'partial.metadata.json' equivalent file exists in
Util.read_metadata, but I didn't commit it because I was unsure if you'd prefer people just manually rename their metadata files.