Chrome extension #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for gleaming-sunshine-5cea24 failed.
|
✅ Deploy Preview for vaspacx-chrome-ext ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dev-enforced
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
The live preview hosted on Netlify is working well code structure looks good and easy to understand
- Awesome use of barrel exports and imports for importing multiple components and styles in a single line. Still at some more places can use it do check the codebase once to make sure of it.
- Remove commented useEffect based code and debuggers like console logs for checking the output.
- Good use of Animation libraries while developing landing page of the project👏🏻💯. Styled components reduced the abstraction while writing down components completely minimizing the use of CSS selectors
- Got to see a new approach of using redux toolkit along with managing local storage based variables with useEffect hook.
Awesome work on the extension Vashnavi. Got to learn & of course ask a lot🙂💯🚀
| import { getDataActions } from "../store/extData"; | ||
|
|
||
| const MainPage = () => { | ||
| const dateValue = useSelector((state) => state.extData.dateStore.date); |
There was a problem hiding this comment.
Can write it altogether using object destructing as
const {dateStore:{date,month,year},flag} = useSelector((state)=>state.extData)| DetailContainer, | ||
| UpperBox, | ||
| } from "../components"; | ||
| import SpecialCountdown from "../components/CountDown"; |
There was a problem hiding this comment.
Can use barrel exports for components from L11-L19.
| city !== null | ||
| ? `q=${city}` | ||
| : `lat=${coordinates.latitude}&lon=${coordinates.longitude}` | ||
| }&appid=021cbeb6524e6c10b8d5ac497d7e73a3` |
There was a problem hiding this comment.
Can store this private data in an env variable otherwise the weather component might not work properly due to misuse of secret API key.
| @@ -1,8 +1,15 @@ | |||
| import { useSelector } from "react-redux"; | |||
| import { BgWrapper, GlobalStyle } from "./components"; | |||
| import MainPage from "./page/MainPage"; | |||
srishtigautam21
approved these changes
Sep 21, 2022
ashishkatiyar2404
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
live url:-https://vaspacx-chrome-ext.netlify.app/