aiohttp exceptions, semaphore leak, asyncio.sleep #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not get caught Use `asyncio.sleep` instead of time.sleep(), which can cause entire event loop to pause
maya-undefined
changed the title
edgaratvast
reviewed
Oct 17, 2025
| except ValueError as e: | ||
| log.debug(f"Error downloading key: {e}") | ||
| time.sleep(15) | ||
| await sleep(15) |
Contributor
There was a problem hiding this comment.
_fetch_pubkey is not guaranteed to be only called in an async context; we should mark it (and its whole calling chain) async if it needs to be called in an async context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client is aiohttp but we are catching a requests exception which may not get caught
Use
asyncio.sleepinstead of time.sleep(), which can cause entire event loop to pause.There is also a possible semaphore leak. We acquire the semaphore under a branch but we release it in the finally in all cases.