Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-stack): implement actions and clipboard for VM console #8125

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Nov 8, 2024

Screenshot

Capture d’écran de 2024-11-08 16-48-20

Description

This is a first implementation of the Console page for XO6/Lite.
This figma page is not up to date, so once the page is cleaned by Clémence, there will probably be things to rewrite in this part of the code.

Actions are disabled on XO6 because the logic need to be implemented first.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MathieuRA MathieuRA force-pushed the web-core-console-panel branch 2 times, most recently from 1b50d4e to aba715c Compare November 8, 2024 14:57
@MathieuRA MathieuRA self-assigned this Nov 8, 2024
@MathieuRA MathieuRA force-pushed the web-core-console-panel branch 2 times, most recently from 3c68c9c to 0337b3f Compare November 12, 2024 08:45
Copy link
Contributor

@J0ris-K J0ris-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, is it necessary to have a fullscreen and an “open in another tab” ? If yes, the fullscreen should have a cross to close or at least be able to escape. To see with @clemencebx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants