feat(xo-web): ability to block/unblock migration #8129

stephane-m-dev · 2024-11-13T13:10:29Z

Description

VM : add ability to block / unblock migration

XO-389
https://project.vates.tech/vates-global/projects/70ab2907-1ac3-4e7d-831f-a8752c36474d/issues/b8c25c6d-40ba-4cb6-8a6c-33d887692525

UPDATED : change TabButton to Toggle

UPDATED : add confirm modal on Toggle

Checklist

Commit
- Title follows commit conventions
- Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
- If bug fix, add Introduced by
Changelog
- If visible by XOA users, add changelog entry
- Update "Packages to release" in CHANGELOG.unreleased.md
PR
- If UI changes, add screenshots
- If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

develop skills of junior reviewers

limit the workload for senior reviewers

limit the number of unnecessary changes by the author

The author creates a PR.
Review process:
1. The author assigns the junior reviewer.
2. The junior reviewer conducts their review:
  - Resolves their comments if they are addressed.
  - Adds comments if necessary or approves the PR.
3. The junior reviewer assigns the senior reviewer.
4. The senior reviewer conducts their review:
  - If there are no unresolved comments on the PR → merge.
  - Otherwise, we continue with 3.
The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

The author can request a review at any time, even if the PR is still a Draft.
In theory, there should not be more than one reviewer at a time.
The author should not make any changes:
- When a reviewer is assigned.
- Between the junior and senior reviews.

b-Nollet · 2024-11-13T13:43:38Z

packages/xo-web/src/common/xo/index.js

+}
+
+export const vmAllowMigration = async vm => {
+  const reason = 'VM migration is blocked during backup'


As this value is shared by the two functions you added, it should probably be put in a constant outside the function.

I changed the TabButton to Toggle, this code was completely removed.

b-Nollet · 2024-11-13T13:54:01Z

packages/xo-web/src/xo-app/vm/tab-advanced.js

@@ -780,6 +784,13 @@ export default class TabAdvanced extends Component {
                  labelId='vmWarmMigration'
                  tooltip={isWarmMigrationAvailable ? undefined : _('availableXoaPremium')}
                />
+                <TabButton
+                  btnStyle='warning'
+                  handler={isMigrationAllowed ? vmBlockMigration : vmAllowMigration}


As I understand this, it would let users click the "Allow migration" button even when migrations are blocked for another reason (i.e. when vm.blockedOperations.migrate_send === 'another reason than "VM migration is blocked during backup"'), which means clicking the button won't change anything.
Maybe we can gray out the button in such case, or display an information message?

We don't want to prevent the user from unblocking the migration, even if it has been blocked by the backup.

For instance, there might be an issue with the backup which prevented it from unblocking the operation at then end, and we want users to be able to bypass this.

But I think it would make sense to display the current reason it is blocked before unblocking, maybe by showing a modal (and only if the reason is not trivial, i.e. 'true').

@julien-f Can we already ship the feature like this, and maybe improve it later?
Or do you want it to be improved now?

I fear that doing it in two steps will in fact make it more work and take longer.

IMHO that adding a quick confirm should be quick, what do you think @pdonias (of both the idea and how to implement it)?

I agree. It gives more feedback and doesn't prevent the user from doing anything while keeping it safe. I think a simple confirm modal in vmAllowMigration that shows the reason is enough.

@pdonias Do you think that someone could help on the front-side?

julien-f · 2024-11-13T16:18:13Z

packages/xo-web/src/xo-app/vm/tab-advanced.js

+                  handlerParam={vm}
+                  icon='vm-allow-migration'
+                  labelId={isMigrationAllowed ? 'vmBlockMigration' : 'vmAllowMigration'}
+                />


It seems I lost a comment there: use a toggle button like other blocked operations.

What I previously meant is: do not create a function that will switch the state as it can behave strangely if the cache is not up-to-date, the customer should be able to see whether it will block or unblock when clicking on the button.

That's what I did: I split my toogle function into two different functions, and the button indicates whether it is used to block or unblock (as shown on the screenshots at the top of the PR).
What's wrong for you?

I want this feature to be displayed the same way other blocked operations are displayed:

@julien-f OK it's clearer with a picture! I'll change that.

velvetrevolver force-pushed the ability-to-block-migration branch from 1a9ec93 to 41daaa7 Compare November 13, 2024 13:14

stephane-m-dev changed the title ~~feat(xo-server/xo-web): ability to block migration~~ feat(xo-web): ability to block migration Nov 13, 2024

stephane-m-dev requested a review from b-Nollet November 13, 2024 13:19

b-Nollet requested changes Nov 13, 2024

View reviewed changes

b-Nollet requested a review from fbeauchamp November 13, 2024 13:55

stephane-m-dev force-pushed the ability-to-block-migration branch from 41daaa7 to 330965a Compare November 13, 2024 13:59

stephane-m-dev changed the title ~~feat(xo-web): ability to block migration~~ feat(xo-web): ability to block/unblock migration Nov 13, 2024

julien-f reviewed Nov 13, 2024

View reviewed changes

stephane-m-dev force-pushed the ability-to-block-migration branch 3 times, most recently from da1b169 to 12d859b Compare November 15, 2024 09:18

stephane-m-dev added 3 commits November 15, 2024 15:50

feat(xo-web): ability to block/unblock migration

d0a1361

change TabButton to Toggle

2bd72cd

add confirm modal

4742eaa

stephane-m-dev force-pushed the ability-to-block-migration branch from 12d859b to 4742eaa Compare November 15, 2024 14:53

stephane-m-dev added 2 commits November 15, 2024 17:25

fix modal confirm

e9716a6

remove logs

7417aa7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(xo-web): ability to block/unblock migration #8129

feat(xo-web): ability to block/unblock migration #8129

stephane-m-dev commented Nov 13, 2024 •

edited

Loading

b-Nollet Nov 13, 2024

stephane-m-dev Nov 14, 2024

b-Nollet Nov 13, 2024

julien-f Nov 13, 2024

stephane-m-dev Nov 14, 2024

julien-f Nov 14, 2024

pdonias Nov 14, 2024

julien-f Nov 14, 2024

julien-f Nov 13, 2024

stephane-m-dev Nov 13, 2024

julien-f Nov 14, 2024

stephane-m-dev Nov 14, 2024

feat(xo-web): ability to block/unblock migration #8129

Are you sure you want to change the base?

feat(xo-web): ability to block/unblock migration #8129

Conversation

stephane-m-dev commented Nov 13, 2024 • edited Loading

Description

Checklist

Review process

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephane-m-dev commented Nov 13, 2024 •

edited

Loading