Skip to content

Add legal section including appropriate attribution#428

Merged
alphadelta332 merged 4 commits intovatpac-technology:mainfrom
glennawatson:glennawatson/attribution
Jan 6, 2025
Merged

Add legal section including appropriate attribution#428
alphadelta332 merged 4 commits intovatpac-technology:mainfrom
glennawatson:glennawatson/attribution

Conversation

@glennawatson
Copy link
Copy Markdown
Contributor

Summary

Adds legal attribution page. Includes licenses to all the tools used during the production of the website.

Changes

Additions:

  • Add legal attribution notices.

@glennawatson
Copy link
Copy Markdown
Contributor Author

glennawatson commented Dec 29, 2024

Attribution is something I've myself had to be very careful about the past. Have had creators come ask their work be credited in the past. I've scanned the entire repo, including the CSS looking for any custom stuff I can attribute to and included it in this doc.

Happy to change styling or whatever, and also added a area for you guys to include other legal docs in the future.

@mattk04
Copy link
Copy Markdown
Collaborator

mattk04 commented Dec 30, 2024

Thanks Glenn, appreciate you putting this together for us.

@glennawatson glennawatson changed the title Add legal declarations including appropriate attributes required by l… Add legal declarations including appropriate attribution Dec 30, 2024
@glennawatson glennawatson changed the title Add legal declarations including appropriate attribution Add legal section including appropriate attribution Dec 30, 2024
@wsmart17
Copy link
Copy Markdown
Contributor

Thanks for bringing this to our attention @glennawatson. Just one point of clarification, which I'm hoping you might know a bit more about than me/us. Each of the licences (except CC) mentions something about including a certain piece of text with distributions of the software, so do you think we should be including the content of the licence files on the legal page rather than just a link (or in addition to the link)? I've tried to find some references online to go off of, but everyone seems to have a different opinion on what's needed.

@glennawatson
Copy link
Copy Markdown
Contributor Author

glennawatson commented Dec 30, 2024

Thanks for bringing this to our attention @glennawatson. Just one point of clarification, which I'm hoping you might know a bit more about than me/us. Each of the licences (except CC) mentions something about including a certain piece of text with distributions of the software, so do you think we should be including the content of the licence files on the legal page rather than just a link (or in addition to the link)? I've tried to find some references online to go off of, but everyone seems to have a different opinion on what's needed.

We been having this discussion a lot lately on the board of the .NET foundation board since we have had projects not properly attribute often through not knowing they have to (MIT licenses still require attribution).

We been finding the same issue in terms of resources aren't consistent on recommendations. We wanted to make our own guide for OSS projects but we been warned by legal (Microsoft provides us with limited legal) that unless we pay as a foundation for legal review (we don't have a large amount of cash) we have to be careful offering advice.

The resources we did find:

https://nexb.com/oss-attribution-best-practices/

https://opensource.guide/legal/

The reality is you guys aren't modifying the source code of the projects though so I suspect technically you may not even have to attribute. This is more of a nicety to projects you use and covering your butt document just in case.

I can definitely bring in the individual license text for each project if you want you be super cautious though and leave links as well.

@wsmart17
Copy link
Copy Markdown
Contributor

The word we're struggling with defining is "distribution" - does having web clients download code and run it count as distribution? Happy to go with the conservative assumption that it does, just to make sure we're doing right by package/resource authors. I think the first link you provide has some good examples, I've looked at the Chrome one just now and it includes the licence text for packages used. So to be safe, might be worth including the text as well as a link? I'm happy to make that change if you'd like, I just don't want to hijack your PR.

As a separate change, to help avoid further cluttering the main menu bar, could we link to this page in the footer instead? The template HTML is in overrides/partials/copyright.html. My thought was that we could have it something like this:

image

Again, I'm happy to make that change as well if you'd like, just let me know.

@glennawatson
Copy link
Copy Markdown
Contributor Author

Yeah. Make the changes as you see fit.

@glennawatson
Copy link
Copy Markdown
Contributor Author

glennawatson commented Dec 31, 2024

@wsmart17 one thing I would recommend when you are changing the PR is adding also material, I acknowledged mkdocs-material but not material itself (transient dependencies are hard). Material being the main theme you guys are using.

https://github.com/material-components/material-web/blob/main/LICENSE

In terms of distribution, I guess you are distributing the 'statically' generated website right. The sub-dependencies are all packages and aren't part of the end product, except maybe the CSS/material.

I think regardless if you take your time and just make a good faith effort that's good enough.

Trick is also to make sure people correctly attribute if they are adding new packages to the project.

@wsmart17 wsmart17 requested a review from a team January 5, 2025 07:45
@alphadelta332 alphadelta332 merged commit 185e4e7 into vatpac-technology:main Jan 6, 2025
@glennawatson glennawatson deleted the glennawatson/attribution branch January 6, 2025 12:41
glennawatson pushed a commit that referenced this pull request Mar 24, 2025
Add legal section including appropriate attribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants