Added error handling for empty callsigns

vatpac-technology · Apr 16, 2022 · 1954d00 · 1954d00
1 parent 7a55d2d
commit 1954d00
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 6 deletions.
diff --git a/APIS_README.md b/APIS_README.md
@@ -25,14 +25,23 @@ Route `/flights/`
 #### Arivals
 
 Route `/arrivals/<ICAO code>`
-Returns `[pilot]`
+Returns
+- 200 `[pilot]`
+- 404
+- 500
 
 #### Callsign
 
 Route `/callsign/<callsign>`
-Returns `{pilot}`
+Returns
+- 200 `{pilot}`
+- 404
+- 500
 
 #### Departures
 
 Route `/departures/<ICAO code>`
-Returns `[pilot]`
+Returns
+- 200 `[pilot]`
+- 404
+- 500
diff --git a/config/default.json b/config/default.json
@@ -1,7 +1,7 @@
 {
     "app": {
         "name": "vatsim-map",
-        "version": "0.0.1",
+        "version": "0.0.3",
         "url": "https://github.com/vatpac-technology/vatsim-map/",
         "log_level": 30,
         "http": {

diff --git a/config/production.json b/config/production.json
@@ -1,7 +1,7 @@
 {
     "app": {
         "name": "vatsim-map",
-        "version": "0.0.1",
+        "version": "0.0.3",
         "url": "https://github.com/vatpac-technology/vatsim-map/",
         "log_level": 30,
         "http": {

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "vatsim-map",
   "type": "module",
-  "version": "0.0.1",
+  "version": "0.0.3",
   "description": "Display VATSIM traffic on a map for a given set of FIRs",
   "private": true,
   "dependencies": {

diff --git a/server.js b/server.js
@@ -56,6 +56,8 @@ app.get('/v1/flights/callsign/:callsign', cors(), async (req, res) => {
   const feature = pilots.features.find(e => e.properties.pilot.callsign === req.params.callsign)
   if(feature == false){
     res.sendStatus(500);
+  } else if(feature == undefined){
+    res.sendStatus(404);
   }else{
     res.send(feature.properties.pilot)
   }