Features/fix for issue 291 #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkstrauss
commented
Dec 8, 2025
| ```java | ||
| ObjectMapper mapper = new ObjectMapper(); | ||
| mapper.registerModule(new VavrModule()); | ||
| ObjectMapper mapper = new ObjectMapper().rebuild().addModule(new VavrModule()).build(); |
Author
There was a problem hiding this comment.
There might be a better way than using rebuild, but this was the quickest way without changing the code significantly. This strategy was employed throughout the PR.
| import static tools.jackson.core.JsonToken.VALUE_NULL; | ||
|
|
||
| abstract class ArrayDeserializer<T> extends ValueDeserializer<T> implements ContextualDeserializer { | ||
| abstract class ArrayDeserializer<T> extends VavrValueDeserializer<T> { |
Author
There was a problem hiding this comment.
The local ValueDeserializer/ValueSerializer was renamed due to a naming conflict with Jackson 3's classes of the same names.
src/main/java/io/vavr/jackson/datatype/deserialize/EitherDeserializer.java
Outdated
Show resolved
Hide resolved
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a first attempt at updating vavr-jackson for use to use Jackson 3. I was able to get all tests to run successfully locally.