Skip to content

Activate the WAV loading fast path #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iDavi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Activate the WAV loading fast path #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
grep -q "Public Sub RiffClose" package/Riff.bas
grep -q "Public Function RiffLoad" package/Riff.bas
grep -q "Public Function RiffPlay" package/Riff.bas
sed -n '/^Public Function RiffLoad(/,/^End Function/p' package/Riff.bas | grep -q "RiffTryLoadWavFast"

- name: Validate release asset workflow
shell: bash
Expand Down
12 changes: 11 additions & 1 deletion package/Riff.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4152,7 +4152,17 @@ Public Function RiffLoad(ByVal filePath As String) As Long
RiffSetLastError RiffErrorFileNotFound
Exit Function
End If


Dim wavResult As Long
wavResult = RiffTryLoadWavFast(filePath, slot)

If wavResult >= 0 Then
RiffLoad = wavResult
Exit Function
ElseIf wavResult = RIFF_FAST_WAV_FATAL Then
Exit Function
End If

#If VBA7 Then
Dim pReader As LongPtr
Dim pPartialType As LongPtr
Expand Down
Loading