grafana dashboard and env variables should work in all deployment modes

vdesabou · Nov 26, 2024 · d226b77 · d226b77
1 parent 0754ee6
commit d226b77
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/flink/flink_session_mode/start.sh b/flink/flink_session_mode/start.sh
@@ -4,7 +4,15 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
 # loading env variables
 source ${DIR}/../../scripts/utils.sh
 
+profile_grafana_command=""
+  if [ -z "$ENABLE_JMX_GRAFANA" ]
+  then
+    log "🛑 Grafana is disabled"
+  else
+    log "📊 Grafana is enabled"
+    profile_grafana_command="--profile grafana"
+    playground state set flags.ENABLE_JMX_GRAFANA 1
+  fi
 
 source ${DIR}/../../scripts/flink_download_connectors.sh
-
-docker compose --profile grafana up -d
+docker compose ${profile_grafana_command} up -d
diff --git a/flink/flink_session_mode/stop.sh b/flink/flink_session_mode/stop.sh
@@ -4,6 +4,16 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
 
 source ${DIR}/../../scripts/utils.sh
 
-docker-compose --profile grafana down -v --remove-orphans
+profile_grafana_command=""
+if [ -z "$ENABLE_JMX_GRAFANA" ]
+then
+    log "🛑 Grafana is disabled"
+else
+    log "📊 Grafana is enabled"
+    profile_grafana_command="--profile grafana"
+    playground state set flags.ENABLE_JMX_GRAFANA 1
+fi
+
+docker-compose ${profile_grafana_command} down -v --remove-orphans
 
 stop_all "$DIR"