-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile-v3 milestone 2 delivery #236
Open
JoaoMorais96
wants to merge
2
commits into
vechain:master
Choose a base branch
from
JoaoMorais96:mobilev3-milestone2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
milestone-delivery/deliveries/mobile-v3-swap-milestone-2.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Milestone Delivery :mailbox: | ||
|
||
> Only the GitHub account, which is responsible for the pull request of the accepted application is allowed to submit milestones. Don't remove any of the mandatory parts presented in bold letters or as headlines! | ||
|
||
**The Ethereum address has been filled out correctly for this milestone and the delivery is according to the official [milestone delivery guidelines](../).** | ||
|
||
- **PR Link:** https://github.com/vechain/grant-program/pull/132 | ||
- **Milestone Number:** 2 | ||
|
||
Please provide a list of all deliverables of the milestone extracted from the initial application and a link to the deliverable itself. Ideally all links inside the below table should include a commit hash, which should be used for testing. | ||
|
||
| Number | Deliverable | Specification | Link | | ||
| ------ | ---------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------ | | ||
| 0. | Smart Contract Updates | The contracts were modified in order to be adapted to the existing Dart package capabilities and in order to better suit frontend needs | https://github.com/SayNode/fondue-swap-vechain-contract Commit Hash: 513338c141c2667b7fc5cc430ae51020f0bf057f | | ||
| 1. | Frontend: Design | We will create the UI design in order to make it appealing and intuitive. Colors schemes, button formatting, location of elements, etc, will all be done i this phase. | https://github.com/SayNode/fondue-swap-flutter Commit Hash: 8a98fad7e159828735fb2a09bc2f9c30032aa078 | | ||
| 2a. | Frontend: Development | The previously planned UI will be build and organized. | https://github.com/SayNode/fondue-swap-flutter Commit Hash: 8a98fad7e159828735fb2a09bc2f9c30032aa078 | | ||
| 2b. | Frontend: Integration | The frontend will connect to the contract | https://github.com/SayNode/fondue-swap-flutter Commit Hash: 8a98fad7e159828735fb2a09bc2f9c30032aa078 | | ||
| 2c. | Frontend: Testing | Several tests will be run to make sure everything works correctly: the UI works as intended and page load up speed/performance. The contract interaction is also checked. | https://github.com/SayNode/fondue-swap-flutter Commit Hash: 8a98fad7e159828735fb2a09bc2f9c30032aa078 | | ||
| 2d. | Frontend: Tutorial | Simple guide on how to swap and set, check and change positions. | https://github.com/SayNode/fondue-swap-flutter/blob/main/README.md Commit Hash: 8a98fad7e159828735fb2a09bc2f9c30032aa078 | | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where can I find the application to try on my device?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find the final .apk in this folder https://drive.google.com/drive/folders/1QXoDBafqEP0Hx5QLlLv6EGsjBmH-F3fq?usp=sharing