Skip to content

Conversation

@elohmeier
Copy link
Contributor

Summary

  • allow the prometheus_remote_write source to accept requests on a configurable URL path
  • default to / to preserve existing behaviour
  • add tests ensuring both custom-path success and wrong-path rejection

Vector configuration

[sources.prom_remote_write]
type = "prometheus_remote_write"
address = "0.0.0.0:9090"
path = "/api/v1/write"

How did you test this PR?

cargo test -p vector --lib sources::prometheus::remote_write::test

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Please merge #23773 first. I'll then rebase this PR and resolve the conflict.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@elohmeier elohmeier requested review from a team as code owners October 7, 2025 09:08
@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: external docs Anything related to Vector's external, public documentation labels Oct 7, 2025
@pront pront enabled auto-merge October 21, 2025 16:36
@pront pront added this pull request to the merge queue Oct 21, 2025
Merged via the queue into vectordotdev:master with commit 6f7ef56 Oct 21, 2025
61 checks passed
@elohmeier elohmeier deleted the prom-http-path branch October 21, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants