Skip to content

Conversation

@titaneric
Copy link
Contributor

@titaneric titaneric commented Oct 18, 2025

Summary

As reported in the #23974, the current docker_logs source ignore the specified socket path, and I intend to fix it here.

Vector configuration

api:
  enabled: true
  graphql: true
  playground: true
  address: "127.0.0.1:8686"
sources:
  my_source_id:
    type: docker_logs
    docker_host: unix:///var/run/docker.sock
sinks:
  my_sink_id:
    type: console
    inputs:
    - my_source_id
    encoding:
      codec: raw_message

How did you test this PR?

cargo build --no-default-features --features sources-docker_logs --features sinks-console --features api

./vector -v --config docker-source.yaml

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Closes: #23974

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@titaneric titaneric requested a review from a team as a code owner October 18, 2025 11:57
@thomasqueirozb
Copy link
Contributor

Hi @titaneric thanks for your contribution! This makes sense to me. Since this is something that alters Vector behavior it is considered a user facing change (I edited the PR description already). Could you please add a changelog? Thanks!

@titaneric
Copy link
Contributor Author

titaneric commented Oct 20, 2025

@thomasqueirozb , I update the changelog, please check it.

@pront pront enabled auto-merge October 22, 2025 16:23
@pront pront added this pull request to the merge queue Oct 22, 2025
Merged via the queue into vectordotdev:master with commit 2ead145 Oct 22, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker_logs Source docker_host Parameter Ignored for Unix Sockets

3 participants