feat(reflect): add facts_only mode to exclude chunks and expand tool#1039
Closed
cdbartholomew wants to merge 1 commit intomainfrom
Closed
feat(reflect): add facts_only mode to exclude chunks and expand tool#1039cdbartholomew wants to merge 1 commit intomainfrom
cdbartholomew wants to merge 1 commit intomainfrom
Conversation
When facts_only is enabled, reflect only considers extracted facts — raw source chunks are stripped from recall results, the expand tool is removed from the agent's tool set, and the max_chunk_tokens parameter is hidden from the recall tool schema. Available via the reflect HTTP API (facts_only field) and per-mental-model trigger config (trigger.facts_only), so mental model refreshes can be scoped to synthesized facts without raw document context.
Collaborator
|
added a more complete fix here #1048 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
facts_onlyflag to the reflect API and mental model trigger configmax_chunk_tokensis hidden from the recall schemaChanges
ReflectRequestandMentalModelTrigger— newfacts_only: boolfieldreflect_async/run_reflect_agent— threadfacts_onlythrough to tool setuptool_recall—include_chunksis now a parameter (was hardcodedTrue)get_reflect_tools— conditionally excludes expand tool and chunk params whenfacts_only=Trueagent.py— expand is now governed byenabled_tools(removed from hardcoded exemption)Test plan