fix: improve error handling and clean up scan timers - #8
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
fix: improve error handling and clean up scan timers#8devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
- mcp-server: guardRequest now fails closed (abort) instead of open (continue) - scan-service: check DB update error when marking reports as failed - scan-service: log LLM translation failures instead of silently swallowing - scan-service: log notify.ts alert delivery failures - scan-service: clear timeout timer on scan success to prevent resource leak - scan-service: log screenshot and CMS detection errors - app: validate Supabase env vars with clear error messages - app: handle network errors in scan results page fetchScan - app: surface revenue calculation errors to user - app: guard against invalid JSON from scan service response Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthens failure handling across the frontend and scan service without changing successful request behavior.
unknown, require numericscore/totalViolations, normalizeviolations, and return502for malformed payloads.The branch was reconciled with the shared-package refactor in
master; duplicate SSRF and obsolete CMS-detector edits were intentionally removed.Link to Devin session: https://app.devin.ai/sessions/d0785b2f058f4d33b4a75eff3284f47a
Requested by: @vedantggwp