fix: provider hardening (adversarial review ADV-2/3/7/8/10) - #44
Merged
Conversation
…clamp, search failure discrimination, redirect edges Adversarial-review fixes ADV-2/3/7/8/10: .md variants built on pathname only (origin-root URLs could probe squatter-registrable *.com.md hosts and be accepted as fidelity:full); llms.txt no longer accepted as page content; out-of-range entities clamp to U+FFFD instead of throwing; searchWeb returns discriminated errors so headless updates can tell 'DDG blocked us' from 'nothing new'; redirect hops scheme-allowlisted with a shared deadline; reader cancelled on size abort. 385 tests (12 new). Implemented by codex from spec; verified here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the fresh-eyes adversarial review:
.mdvariant construction crossed hosts on origin-root URLs (docs.foo.com/→docs.foo.com.md, squatter-registrable) with the result accepted asfidelity: full. Now pathname-only, root-skipped, query-safe.llms.txtno longer accepted as specific-page content (was stored as verbatim capture of pages never fetched)385/385 tests (12 new: URL-shape, redirect, entity, anomaly-page classes). Implemented by codex (gpt-5.5) from spec; reviewed + semantically verified here.