fix: honest fidelity aggregation (adversarial review ADV-6/9) - #45
Merged
Conversation
…l bridging, deterministic duplicate resolution Adversarial-review fixes ADV-6/9: articles with zero or unmatched sources report 'unknown' instead of masquerading as 'full' (every ambiguity previously failed toward trust — the wrong direction for a provenance product); raw index matches source_url AND final_url; duplicate captures resolve best-fidelity-then-latest with collision logging; coverage_gaps gains an untracked-provenance section; unknown articles get no false-alarm badges. 373 tests (from spec baseline). Implemented by codex from spec; verified here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every ambiguity in fidelity aggregation previously resolved to 'full' — zero-source articles, unmatched URLs, redirect mismatches all displayed as fully-verified. Now: 'unknown' is a first-class state (no false-alarm badges, but surfaced as untracked provenance in coverage_gaps + hub stats), raw matching bridges final_url redirects, and duplicate captures resolve best-fidelity-then-latest with logged collisions. Implemented by codex (gpt-5.5) from spec; reviewed here.