-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature flag for logging #5
Comments
That's a great idea, thank you. General refactoring is already planned for a new minor release sometime in the near future, so this could very well be part of that. |
The solution to this issue will be implemented like the |
Decided to postpone this too for a later release because the implementation resulted quite tricky and I don't want to invest too much energy on it right now. I leave a sketch of a possible solution here. It doesn't compile, tries to cloak the macros but it results in some weird scoping issues. I'd consider an alternative solution, if possible. |
Now that we have @Jakobzs, you have worked on
|
I think it would be better to put log statements under a feature flag. Otherwise logs could get filled with extra stuff, or difficult log filtering would need to be implemented. I think it could sometimes be nice to have logs from this crate, however I think dependents should have the option to disable them.
The text was updated successfully, but these errors were encountered: