Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hooks constructor return Result #71

Open
veeenu opened this issue Jan 12, 2023 · 0 comments
Open

Make hooks constructor return Result #71

veeenu opened this issue Jan 12, 2023 · 0 comments
Labels
breaking Fixing this would introduce a breaking change to the API.

Comments

@veeenu
Copy link
Owner

veeenu commented Jan 12, 2023

Up until now, constructing a Hook trait object is considered infallible and panics at will. Implementations are peppered with unwraps. It would be best to change its signature so that it returns Result, in order to allow managing an orderly cleanup.
@veeenu veeenu added the breaking Fixing this would introduce a breaking change to the API. label Jan 12, 2023
@veeenu veeenu added this to the 0.6.0 milestone May 20, 2023
@veeenu veeenu modified the milestones: 0.5.0, 0.6.0 Sep 28, 2023
@veeenu veeenu removed this from the 0.6.0 milestone Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Fixing this would introduce a breaking change to the API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veeenu