Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to transformed_data for reconstructed charts (with from_dict/from_json) #3102

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

binste
Copy link
Contributor

@binste binste commented Jul 10, 2023

Addresses vega/vegafusion#354 on the Altair side. Port to VegaFusion will be done by @jonmmease.

@binste binste requested a review from jonmmease July 10, 2023 20:15
Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for working through this @binste, I'll make the same changes to VegaFusion soon.

# When reconstructing a Chart, Altair uses different classes
# then what might have been originally used. See
# https://github.com/hex-inc/vegafusion/issues/354 for more info.
chart = alt.Chart.from_dict(chart.to_dict())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great testing approach!

@binste binste merged commit 84cdd39 into vega:master Jul 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants