Skip to content

Remove redundant typecheck linter #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Mar 13, 2025

Description

This PR removes redundant typecheck from the linters.enable list.

typecheck is not a linter, it doesn't perform any analysis. It's just a way to identify, parse, and display compiling errors and some linter errors.

More info:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Go used when building/testing:

  • 1.22
  • 1.23

How Has This Been Tested?

Execute golangci-lint run locally.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp LandonTClipp merged commit 7af1256 into vektra:master Mar 13, 2025
4 checks passed
@LandonTClipp
Copy link
Collaborator

Thanks!

@alexandear alexandear deleted the remove-typecheck-linter branch March 13, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants