Skip to content

Fix APR math in nextRevenuePoolSettleApr #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
latent-9 wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −7
Open

Fix APR math in nextRevenuePoolSettleApr #2207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecacdf0
Fix APR math in nextRevenuePoolSettleApr
latent-9 Aug 10, 2026
1cb9f78
sdk: use integer mul/div for settles-per-year in nextRevenuePoolSettl…
latent-9 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions sdk/src/math/insurance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function nextRevenuePoolSettleApr(
SpotBalanceType.DEPOSIT
);

const payoutRatio = 0.1;
const payoutRatioDenominator = 10;
const ratioForStakers =
spotMarket.insuranceFund.totalFactor > 0 &&
spotMarket.insuranceFund.userFactor > 0 &&
Expand All @@ -30,15 +30,16 @@ export function nextRevenuePoolSettleApr(
const revSettlePeriod =
spotMarket.insuranceFund.revenueSettlePeriod.toNumber() * 1000;

const settlesPerYear = 31536000000 / revSettlePeriod;

const projectedAnnualRev = revenuePoolBN
.muln(settlesPerYear)
.muln(payoutRatio);
.mul(new BN(31536000000))
.div(new BN(revSettlePeriod))
.divn(payoutRatioDenominator);

const delta = amount ?? ZERO;

const uncappedApr = vaultBalance.add(amount).eq(ZERO)
const uncappedApr = vaultBalance.add(delta).eq(ZERO)
? 0
: projectedAnnualRev.muln(1000).div(vaultBalance.add(amount)).toNumber() *
: projectedAnnualRev.muln(1000).div(vaultBalance.add(delta)).toNumber() *
100 *
1000;
const cappedApr = Math.min(uncappedApr, MAX_APR.toNumber());
Expand Down