Skip to content

Commit

Permalink
fix not returning arm template errors (Azure#3288)
Browse files Browse the repository at this point in the history
  • Loading branch information
hawkowl authored and ventifus committed Feb 7, 2024
1 parent 311c08f commit 683692a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/util/steps/refreshing.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (s *authorizationRefreshingActionStep) run(ctx context.Context, log *logrus
// We use the outer context, not the timeout context, as we do not want
// to time out the condition function itself, only stop retrying once
// timeoutCtx's timeout has fired.
err := s.f(ctx)
err = s.f(ctx)

// If we haven't timed out and there is an error that is either an
// unauthorized client (AADSTS700016) or "AuthorizationFailed" (likely
Expand All @@ -83,6 +83,7 @@ func (s *authorizationRefreshingActionStep) run(ctx context.Context, log *logrus
err = s.auth.Rebuild()
return false, err // retry step
}
log.Printf("non-auth error, giving up: %v", err)
return true, err
}, timeoutCtx.Done())

Expand Down

0 comments on commit 683692a

Please sign in to comment.