Remove 7zip BLOBs #3229
Open
Remove 7zip BLOBs #3229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a thought, your PR can add that github action to ventoy/ventoy repo itself. no need for an additional repo (even if owned by ventoy) |
|
so, um, is this going to be merged/changed to be able to merge? |
Probably not due to #3229 (comment) I see no reason why the 7z build system should be owned by someone different than ventoy themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #3224 I have created a Ventoy-7zip repository which is a fork of the upstream 7zip mirror to create reproducible 7za.exe for 32-bit and 64-bit.
This upgrades to the newest 7-zip release (24.09).
The executables will not match exactly since we do not know the 7zip maintainers exact build configuration as they are not documented. Anyone can reproduce my build since it was produced by the GitHub workflow runner.
In the future when 7zip releases updates we can upgrade the Ventoy binaries easily:
This would work best if you owned the repository. You could either recreate this yourself or consider turning your project into a GitHub organization to manage the dependencies and/or the main repository. This could allow other to more easily help you.