Skip to content

Conversation

@pranjalkole
Copy link

We could also refactor this to a validateCWTClaims function in cwt.go

@SteveLasker
Copy link
Contributor

@veraison/go-cose-maintainers, can we get some 👀's on this?

@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 3.63636% with 53 lines in your changes missing coverage. Please review.

Project coverage is 89.18%. Comparing base (eb9cdec) to head (c88a9da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
headers.go 3.63% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   91.12%   89.18%   -1.95%     
==========================================
  Files          12       12              
  Lines        2006     2053      +47     
==========================================
+ Hits         1828     1831       +3     
- Misses        122      168      +46     
+ Partials       56       54       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Pranjal Kole <[email protected]>
@SteveLasker
Copy link
Contributor

@shizhMSFT, @qmuntal, @thomas-fossati can you PTAL?

Co-authored-by: Shiwei Zhang <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker
Copy link
Contributor

@pranjalkole can you please take a look at above changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants