Rework arguments to models.stream and Agents.run - #94
Closed
msullivan wants to merge 3 commits into
Closed
Conversation
Update all callers in src/, tests/, examples/, and README to pass `model=` and `messages=` explicitly.
Adds a `StreamContext` Protocol (so the model layer doesn't have to import the agents package) and overloads `stream` to accept either a context positionally or explicit `model=`/`messages=`/`tools=` kwargs. The runtime check rejects mixing the two forms. Updates the default agent loop, all custom-loop examples, and the context-bearing tests to use the shorthand.
Mirrors the kwargs-only style now used by `stream`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Somehow this looks more verbose than the old version |
anbuzin
approved these changes
May 11, 2026
Contributor
Author
|
Closing in favor of #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
modelandmessageskeyword only for bothstreamandrun,but also allow
runto takeContextpositionally. Enforced viaoverloads and at runtime.
This was a plan we discussed but I'm not totally sure that I love the
results? Thoughts?