chore: fix release workflow#37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
See https://github.com/vercel-labs/konsistent/actions/runs/28108086504/job/83227713715: The
release.ymlworkflow was failing because it was missing thenode_modulesremoval that's necessary withpnpm11, per the workaround that's already inci.yml.The other problem is https://github.com/vercel-labs/konsistent/actions/runs/28108155991/job/83227961536?pr=32: For a new package (i.e. version is set to
0.0.0), we have to require amajorchangeset - only otherwisepatchis required.Relevant technical choices
release.ymlwith how it works inci.ymlmajorchangeset for packages with version 0.0.0, else requirepatchChecklist
pnpm changesetin the project root if package files were modified)