fix: support check/update for local skills#642
Open
elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: support check/update for local skills#642elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Local skills were always skipped by `skills check` and `skills update` because these commands only used GitHub API for hash comparison. Changes: - Compute and store a folder hash when installing local skills via `computeSkillFolderHash()`, so changes can be detected later - In check/update, compare the stored hash against a freshly computed hash from the source path instead of calling GitHub API - Local skills without a stored hash show an improved skip message suggesting reinstall to enable tracking Closes vercel-labs#522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #522
skills checkandskills updatenow work with locally installed skills.Problem
Local skills (installed via
npx skills add ./path) were always skipped bycheckandupdatebecause:getSkipReason()returned'Local path'for all local sourcesskillFolderHashandskillPath— but local skills had neither stored at install timefetchSkillFolderHash) was the only hash comparison methodSolution
At install time (
add.ts)computeSkillFolderHash()and store it inskillFolderHashAt check/update time (
cli.ts)Skip message improvement
'Local path (no hash recorded — reinstall to enable tracking)'Testing
pnpm build✅pnpm test✅ (375/375 tests pass)