fix: use typed .env() method for git prompt suppression#649
Open
elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: use typed .env() method for git prompt suppression#649elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Replace the untyped `env` constructor option in `simpleGit()` with
the typed `.env()` method chain. The `env` property is not part of
simple-git's `SimpleGitOptions` interface, causing a TypeScript
overload mismatch.
Before (untyped):
simpleGit({ timeout: ..., env: { GIT_TERMINAL_PROMPT: '0' } })
After (typed):
simpleGit({ timeout: ... }).env('GIT_TERMINAL_PROMPT', '0')
`GIT_TERMINAL_PROMPT=0` still suppresses interactive prompts
during clone.
Closes vercel-labs#618
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #618
The
simpleGit()constructor receives anenvproperty that is not part of the typedSimpleGitOptionsinterface, causing a TypeScript overload mismatch error.Before
After
Notes
GIT_TERMINAL_PROMPT=0still suppresses interactive prompts during clone.env()method is part of simple-git's public API and properly typedsrc/git.tsTesting
All 375 tests pass (1 pre-existing timeout in sync.test.ts unrelated to this change).