fix: preserve URL scheme in well-known source identifier#670
Open
elliotllliu wants to merge 2 commits intovercel-labs:mainfrom
Open
fix: preserve URL scheme in well-known source identifier#670elliotllliu wants to merge 2 commits intovercel-labs:mainfrom
elliotllliu wants to merge 2 commits intovercel-labs:mainfrom
Conversation
`getSourceIdentifier()` stripped the scheme from well-known URLs, storing only the hostname (e.g. 'react-spectrum.adobe.com') in the lock file. When `experimental_install` later passed this source to `runAdd()`, it failed to clone because the string wasn't a valid URL. Now preserves the full scheme (e.g. 'https://react-spectrum.adobe.com') so the source can be re-used directly for reinstallation. Fixes vercel-labs#666
Tests now expect the full URL with scheme (e.g. 'https://example.com') instead of hostname-only ('example.com'), matching the fix that preserves the URL scheme for experimental_install compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #666 —
experimental_installfails for well-known skills because thesourceinskills-lock.jsonis missing the URL scheme.Root Cause
WellKnownProvider.getSourceIdentifier()only returned the hostname (e.g.react-spectrum.adobe.com), stripping thehttps://scheme. Whenexperimental_installlater passed this source torunAdd(), it tried to clonereact-spectrum.adobe.comas a git repo, which fails.Fix
Preserve the full URL with scheme in
getSourceIdentifier():Before:
react-spectrum.adobe.comAfter:
https://react-spectrum.adobe.comTesting
npx skills add https://react-spectrum.adobe.comstoreshttps://react-spectrum.adobe.comas sourcenpx skills experimental_installsuccessfully reinstalls the skillwww.prefix is still stripped for cleanliness