fix: use SEARCH_API_BASE for all links in find output#687
Open
elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: use SEARCH_API_BASE for all links in find output#687elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
elliotllliu wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Replace hardcoded 'https://skills.sh/' URLs in skill detail links, selected skill links, and the discovery footer with the configurable SEARCH_API_BASE constant (which respects SKILLS_API_URL env var). This ensures self-hosted/internal deployments show correct links matching their configured search API endpoint. Closes vercel-labs#686
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #686 — replaces hardcoded
https://skills.sh/URLs inskills findoutput with the configurableSEARCH_API_BASEconstant.Problem
src/find.tsalready respectsSKILLS_API_URLenv var for the search API request, but result rendering still hardcodeshttps://skills.sh/for skill links and the discovery footer. This means self-hosted deployments show links to the wrong host.Changes
Three hardcoded
https://skills.sh/occurrences replaced with${SEARCH_API_BASE}:└ https://skills.sh/{slug})View the skill at ...)Discover more skills at ...)The default value (
https://skills.sh) is unchanged, so behavior is identical for non-customized environments.