-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update README to correct cloning instructions for Node.js Hello World and Express example #994
Open
developerjhp
wants to merge
2
commits into
vercel:main
Choose a base branch
from
developerjhp:fix-solutions-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous README instructions for cloning the repository were incorrect, as Git does not support cloning a specific subdirectory. This update modifies the instructions to: - Clone the entire repository. - Navigate to the specific example directory. - Ensure the process is clear for users to deploy the Node.js Hello World example using Vercel CLI.
The previous README for the express example contained incorrect instructions for cloning the repository by attempting to clone a subdirectory, which is not supported by Git. This update modifies the README to: - Guide users to clone the entire repository and navigate to the correct example directory.
developerjhp
requested review from
okbel,
lfades,
goncy,
dominiksipowicz,
leerob and
lpalmes
as code owners
December 26, 2024 03:42
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@developerjhp is attempting to deploy a commit to the Vercel Examples Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous README instructions for cloning the repository were incorrect, as Git does not support cloning a specific subdirectory. This update modifies the instructions to:
This change addresses the issue reported in #992.
Description
The previous README contained incorrect instructions for cloning the repository. This PR updates the instructions to:
This change ensures users can successfully follow the README to deploy the Node.js Hello World example.
Demo URL
Not applicable for this change as it only involves documentation updates.
However, the steps in the README were tested locally to ensure correctness.